Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Spring compilation error in gen interfaces with "defaultInterfaces" to false #10980

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

castelblanque
Copy link

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master branch for changes related to OpenAPI spec 2.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. -> No one for Java spring

Description of the PR

Language: JavaSpring
Base version: 2.4.19

Problem summary:
Jdk8 generated interfaces for Spring fail to compile due to missing semicolon when "defaultInterfaces" option set to false.

How to reproduce:

  • Set configuration option defaultInterfaces to false

Fixes #10945

@castelblanque
Copy link
Author

@HugoMario Travis CI is failing in all latest PR, not only mine.

@HugoMario
Copy link
Contributor

thanks a lot @castelblanque for PR !!!

@HugoMario HugoMario merged commit 1d5c030 into swagger-api:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring-Boot server: compilation error in generated interface (missing semicolon)
2 participants