Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Javascript] Remove deprecated querystring dependency. #12226

Merged
merged 3 commits into from
Feb 11, 2024

Conversation

HEYGUL
Copy link
Contributor

@HEYGUL HEYGUL commented Aug 30, 2023

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

querystring javascript dependency has been deprecated.
Nodejs now includes URLSearchParams covering the exact same behavior than querystring.

This PR aims to remove the need and usage of querystring taking advantage of URLSearchParams native API.

@HEYGUL
Copy link
Contributor Author

HEYGUL commented Aug 30, 2023

CC @CodeNinjai

@HEYGUL HEYGUL marked this pull request as ready for review August 30, 2023 21:01
@HEYGUL HEYGUL force-pushed the remove-querystring branch from 66b59ab to 5f09a84 Compare August 30, 2023 21:41
@HEYGUL HEYGUL force-pushed the remove-querystring branch from 6a6078e to 8628047 Compare December 11, 2023 08:03
@HEYGUL
Copy link
Contributor Author

HEYGUL commented Dec 11, 2023

To keep a clean and simple diff, I rebased the branch with master.

@HugoMario HugoMario self-assigned this Feb 10, 2024
@HugoMario
Copy link
Contributor

Thanks a lot for this PR @HEYGUL !!!

@HugoMario HugoMario merged commit 0f7dea0 into swagger-api:master Feb 11, 2024
9 of 12 checks passed
@HEYGUL HEYGUL deleted the remove-querystring branch February 28, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants