Skip to content

typescript-angular2 query string fix#2864

Merged
wing328 merged 1 commit intoswagger-api:masterfrom
revaultch:master
May 23, 2016
Merged

typescript-angular2 query string fix#2864
wing328 merged 1 commit intoswagger-api:masterfrom
revaultch:master

Conversation

@revaultch
Copy link
Contributor

This should fix the following problems, I ran into:

  1. typescript complaining: "Cannot create property 'xxx' on string '' " (string treated as map)
  2. I have a subclass of RequestOptions which will call merge, which behind the scenes calls clone which isn't implemented on string

@wing328
Copy link
Contributor

wing328 commented May 16, 2016

@Vrolijkx would you review the change when you've time? Thanks.

@wing328 wing328 added this to the v2.2.0 milestone May 16, 2016
@Vrolijkx
Copy link
Contributor

Looks ok for me if the build passes.
Didn't know URLSearchParams existed but it certainly makes the code look more robust.

@wing328
Copy link
Contributor

wing328 commented May 18, 2016

@revaultch would you please rebase on the latest master to resolve the merge conflicts?

@wing328 wing328 merged commit 9b9d585 into swagger-api:master May 23, 2016
@wing328
Copy link
Contributor

wing328 commented May 23, 2016

@revaultch thanks for your contribution.

@wing328
Copy link
Contributor

wing328 commented May 23, 2016

@revaultch btw, I would suggest make the change in a new branch (as per Git best practices)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants