Feature/typescript angular2 should generate correct output #2917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/Vrolijkx/swagger-codegen # Conflicts: # modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/AbstractTypeScriptClientCodegen.java
… into feature/node-promise-cleanup
+ added integration test
| type = swaggerType; | ||
| } | ||
|
|
||
| if (!languageSpecificPrimitives.contains(type)) { |
There was a problem hiding this comment.
this will still produce invalid typescript for e.g. Array as with the <> it will not be recognized, my suggestions is to add a starts with check:
private boolean startsWithLanguageSpecificPrimitiv(String type) {
for (String langPrimitive:languageSpecificPrimitives) {
if (type.startsWith(langPrimitive)) {
return true;
}
}
return false;
}
Contributor
Author
There was a problem hiding this comment.
That would be a good workaround for now. Will add it when i have some time.
Personally I think it would be better to start using imports correctly in the future instead of prefixing everything with models.
There was a problem hiding this comment.
@brosenberger , how can I reproduce this bug (before @Vrolijkx fix)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix #2906 contains also changes from #2915 so better to review and merge this one first.