Skip to content

Conversation

@mateuszmackowiak
Copy link
Contributor

No description provided.

Mateusz Mackowiak added 2 commits May 25, 2016 18:13
- License in all header files
- Moved adding License file to DefaultGenerator
}
} No newline at end of file

static public class GlobalSupportingFile extends SupportingFile {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason this class is nested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I treat this as a integral part of the SupportingFile but I can move it to separate place.

@jimschubert
Copy link
Contributor

If our goal is to include a LICENSE file for all generated client and server code, you could do like I did for the .swagger-codegen-ignore and write it at the end if it doesn't exist. See this part of DefaultGenerator.

We'd probably need to discuss a common convention of naming the file LICENSE. This wouldn't address license headers in code files, but it would ensure the license exists in all generated code.

@wing328 wing328 merged commit ef66f96 into swagger-api:master May 28, 2016
@wing328
Copy link
Contributor

wing328 commented May 28, 2016

@mateuszmackowiak thanks for the PR. Later when you've time, can you please add documentation to modules/swagger-codegen/src/main/java/io/swagger/codegen/GlobalSupportingFile.java and its methods?

@wing328
Copy link
Contributor

wing328 commented May 29, 2016

@jimschubert I've reused your code to add a default license for all generators (as we cover too many languages/frameworks) and filed #2993.

@jimschubert
Copy link
Contributor

@wing328 Looks good!

@mateuszmackowiak mateuszmackowiak deleted the objc/License branch September 14, 2016 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants