Skip to content

[PHP] Better code injection handling for PHP API client#3224

Merged
wing328 merged 5 commits intoswagger-api:masterfrom
wing328:security_fix
Jun 28, 2016
Merged

[PHP] Better code injection handling for PHP API client#3224
wing328 merged 5 commits intoswagger-api:masterfrom
wing328:security_fix

Conversation

@wing328
Copy link
Contributor

@wing328 wing328 commented Jun 27, 2016

For #3201

@arnested
Copy link
Contributor

LGTM 👍

One thing, though, is the addition of the injection attempt on the host, basepath, and scheme properties in petstore-with-fake-endpoints-models-for-testing.yaml. This make all the test cases fail...

@wing328 wing328 mentioned this pull request Jun 28, 2016
@wing328
Copy link
Contributor Author

wing328 commented Jun 28, 2016

@arnested thanks for reviewing. We will probably need to create another spec to cover different code injection scenarios.

@wing328
Copy link
Contributor Author

wing328 commented Jun 28, 2016

A couple of update:

  • create a new swagger spec for security tests
  • add the same security fix to PHP server generator: Lumen, Silex, Slim but the code won't compile and we will address those one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants