[C#] better code injection handling for C# API client#3249
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Jun 29, 2016
Merged
[C#] better code injection handling for C# API client#3249wing328 merged 2 commits intoswagger-api:masterfrom
wing328 merged 2 commits intoswagger-api:masterfrom
Conversation
| } | ||
|
|
||
| @Override | ||
| public String escapeQuotationMark(String input) { |
Contributor
There was a problem hiding this comment.
I think this function and escapeUnsafeCharacters need to be heavily commented in all language overrides.
Consider 1 or 2 years down the road:
- This method is removing quotes, not escaping. Why?
- Comment on line 662 could be read as avoiding SQL code injection in generated code. Maybe clarify the comment?
- From a usage perspective, it's not clear whether this is single or double quotes.
- It's not clear the intended context of this method (Mustache templates vs. in generated code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3201