use baseName instead of paramName#3273
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Jul 7, 2016
Merged
Conversation
Contributor
|
@qtstc thanks for the PR. Please do a rebase on the latest master to resolve the merge conflicts. |
|
There is the same issue with SpringMVC and path parameters. |
Contributor
Contributor
Author
|
@wing328 merged conflict resolved |
Contributor
|
@qtstc PR merged. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use baseName instead of paramName in @FormParam().
baseName is the one specified in the "name" field in the schema, and is normally of the form "user_id". I believe paramName is converted from baseName to be used as Java parameter name, and it is of the form "userId".
Currently, for the schema
the generated code would be
@FormParam("userId") String userId. The Jersey framework would then expect the name of the form parameter to be "userId" instead of user_id.We are using the baseName instead of paramName in pathParams.mustache and queryParams.mustache.