Fixed issue [Spring]Add support for the contextPath in Spring-boot gen #3193#3307
Fixed issue [Spring]Add support for the contextPath in Spring-boot gen #3193#3307wing328 merged 1 commit intoswagger-api:masterfrom
Conversation
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors. Let me know if you need help fixing it. Ref: http://stackoverflow.com/questions/3042437/change-commit-author-at-one-specific-commit |
|
Linked commit to my Github account, thank you |
|
cc @cbornet |
| supportingFiles.add(new SupportingFile("swagger2SpringBoot.mustache", | ||
| (sourceFolder + File.separator + basePackage).replace(".", java.io.File.separator), "Swagger2SpringBoot.java")); | ||
| supportingFiles.add(new SupportingFile("application.properties", | ||
| supportingFiles.add(new SupportingFile("application.mustache", |
There was a problem hiding this comment.
@vovan- can you please also do the same for spring-mvc?
There was a problem hiding this comment.
For Spring mvc property 'server.contextPath' means nothing, it is spring-boot related as noted here http://docs.spring.io/spring-boot/docs/current/reference/html/common-application-properties.html
So is there a reason to use same application.properties file for Spring boot and Spring mvc?
There was a problem hiding this comment.
I see. Didn't realise it's for spring boot only. I'll merge the PR shortly.
|
@vovan- PR merged. Thanks for the contribution. |
|
The old "application.properties" should have been deleted from resources ! |
|
Old application.properties are still in use by other type of project - Spring MVC |
|
Oh, I thought it was only renaming. |
3 participants
Fixed issue [Spring]Add support for the contextPath in Spring-boot gen #3193