Fix resteasy offsetdatetime provier#3332
Merged
wing328 merged 11 commits intoswagger-api:masterfrom Aug 15, 2016
Merged
Conversation
Contributor
|
@chameleon82 thanks for the PR. Please run the following to update the Petstore sample and commit the change so that the CI server can test the change: |
Contributor
|
There are some errors reported by the CI. Here is part of the error messages: Full log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/146542250/log.txt Please review and let us know if you need help fixing it. |
| import java.io.InputStream; | ||
|
|
||
| import org.glassfish.jersey.media.multipart.FormDataContentDisposition; | ||
| import org.glassfish.jersey.media.multipart.FormDataParam; |
Contributor
There was a problem hiding this comment.
It seems the sample generation went wrong...
Contributor
Author
|
Hm, looks like no problems in resteasy part |
Contributor
Author
|
Hello @wing328, PR is finished and can be merged. |
Contributor
|
@chameleon82 thanks. I'll take another look. Can you tell us a little bit more about the fix? |
Contributor
Author
|
@wing328 . First, im fixed typo in offsetDateType variable (it was been the same as type and produce collision) and remove unnecessary annotations in provider classes. |
Contributor
|
@chameleon82 thanks for the details. I did a search for |
Contributor
Author
Contributor
Author
|
@wing328 if this PR is not good i can rework it in new PR |
Contributor
|
@chameleon82 thanks for the pointer. It looks good. I'll merge shortly after doing some tests. Thanks again for the PR. |
Contributor
|
@chameleon82 PR merged into master. Thanks again for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.