[Java] Fix @JsonCreator annotation issue with Java API clients using gson #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pulled the latest, regenerated my definition, and I could compile the generated code. I can no longer see @JsonCreator attributes. Kudos for the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was due to not using {{#jackson}} tab to handle the JsonCreator (we've done it for import but not
fromValue) and it's causing issue for Java API clients using gson (okhttp-gson, retrofit, retrofit2)Ran
./bin/java-petstore-all.shto update all Java API client so as to back test API clients using jackson and to confirm API clients using gson no longer having the issue.The issue was caused by #3531 in an attempt to fix deserializaiton issue with jackson.