[PHP] Don't HTML escape PHP pattern output #3672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if (!preg_match("/[a-z]/i", $input['string'])) { | ||
| throw new \InvalidArgumentException('invalid value for $string when calling FakeApi.testEndpointParameters, must conform to the pattern /[a-z]/i.'); | ||
| if (!preg_match("/^[A-Z].", $input['pattern_without_delimiter'])) { |
Contributor
Author
There was a problem hiding this comment.
This regex is missing a trailing slash for some reason.
Contributor
There was a problem hiding this comment.
Did some debugging but no luck. Will open a new issue to track this.
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (NOTE: no need to update all Petstore sample. For instance, only need to update PHP Petstore sample by running./bin/php-petstore.shif updating the PHP code generator or PHP client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
php and lumen patterns should not be HTML entity escaped in output.
With regards to the updated lumen petstore, I see line 106 in samples/server/petstore/lumen/lib/app/Http/Controllers/FakeApi.php contains
"/^[A-Z]."passed to preg_match which will cause apreg_match(): No ending delimiter '/' foundwarning, but that's something not caused by this change.