-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Add a new language generator for undertow-server framework #3820
Conversation
@stevehu thanks for the PR. The CI (travis) reports the following error:
Let me know if you need help fixing it. |
(btw, for your upcoming PRs, I would suggest using a new branch instead of using master as per git best practices) |
I am new to travis. Could you point me to the right location to the issue? Or help me to fix it if it takes longer to teach me:) |
@wing328 I have fixed the ci issue. Yes. I will create a new branch instead of using master. Thanks for the great work! |
@stevehu thanks for the PR, which looks good to me. |
I tweeted about the Undertow generator: https://twitter.com/wing328/status/777882746966253572 Please help retweet to promote the new generator. Thanks! |
K3OhIo062fXjas5ipL4gF+3ECImjWzirQP8UiAfM0/36x7rtAu3btH/qI9hSyx39LBPPE5AsDJZ4 | ||
dSMwNTW1gqmBAZIj+zQ/RD5dyWfPwON7Q+t96YbK6WBuYo0xy+I+PjcUgrWYWP3N24hlq8ZBIei+ | ||
BudoEVJlIlmS0aRCuP8n | ||
-----END CERTIFICATE----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this certificate for?
This is a default public key certificate for distributed jwt token Here are the links for more info about the framework. https://github.com/networknt/undertow-server I have a long lived token in the readme.md of undertow-server-oauth2 for On Mon, Sep 19, 2016 at 11:10 AM, Paŭlo Ebermann notifications@github.com
|
Hmm, I just fear that with this we get many production servers which all accept the same token, just because people don't recognize that there is one. It is a similar case to routers with default passwords going live. Maybe a better solution would be to generate a new key pair (and possibly a test token) each time? |
Also I'm not sure everybody wants OAuth2/JWT auth. This is normally something that is declared in securityDefinitions field of swagger spec. |
@p the demo certificate can only verify the tokens issued by my mock oauth2 @C we assume most people will use oauth2 in the first place but leave it On Mon, Sep 19, 2016 at 11:41 AM, Christophe Bornet <
|
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0
branch for breaking (non-backward compatible) changes.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Add a new language generator for https://github.com/networknt/undertow-server. The framework is built on top of undertow core http and supports most features needed for dockerized macro services. It can serve 1.2 million requests per second for "Hello World" on my i5 desktop. Thanks.