Allow Java source formatting mvn formatter:format #4214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
More work towards our code style standards aim #3972.
Uses Eclipse formatting tools with a configuration matching Google's style guide (plus our customisations).
This brings in an appropriately configured Java formatter maven plugin, but doesn't run it as part of the build. To manually run it:
mvn formatter:formatHaving done this once, we fix ~2200 code style warnings.
I haven't included the results of a run in this PR, as it would generate lots of merge conflicts... I'd suggest whoever merges this PR does a once-off formatter run.