Skip to content

Conversation

@taxpon
Copy link
Contributor

@taxpon taxpon commented Dec 23, 2016

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Fix for issue #4391.

My fix is including adding safe argument to quote method in python template to avoid unquoted parameter appearing in using path parameter.

@taxpon taxpon changed the title add safe argument to quote method in python template to avoid unquote… [Python] Add safe argument to quote method in python template to avoid unquote… Jan 4, 2017
@taxpon
Copy link
Contributor Author

taxpon commented Jan 4, 2017

@wing328 Could you check this PR? Thanks

@wing328 wing328 merged commit 6a080d3 into swagger-api:master Jan 5, 2017
@wing328
Copy link
Contributor

wing328 commented Jan 5, 2017

@taxpon looks good to me. Thanks for your contribution.

@wing328 wing328 added this to the v2.2.2 milestone Jan 5, 2017
@taxpon taxpon deleted the issue-4391 branch January 5, 2017 21:58
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants