[java] Improve pom.xml to qualify for publishing to Maven central #4470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed during deploy phase.
… into maven-central-ready-pom
…assume all users will perform a release/deploy from an environment with correct GPG key/pass.
Contributor
Author
|
@wing328 Travis test failure is related to Clojure petstore and I don't think it has anything to do with my pom template changes. Any idea? |
Contributor
|
@cliffano there's an issue with Clojure Petstore client after updating the code (not related to your PR at all). I think what I'll do is to cherry pick the commits in your PR. |
Contributor
Author
|
@wing328 Any chance to cherry pick this PR? |
Contributor
|
@cliffano I'll do it over the weekend. |
Contributor
Contributor
Author
|
@wing328 LGTM. |
Contributor
|
Thanks for reviewing the PR (#4616), which has been merged into master. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made the following changes to all Java-related pom.xml templates so the generated pom qualifies for publishing to Maven central:
This PR was tested (and the petstore generated) using swagger-parser 1.0.24 due to the issue with 1.0.25-SNAPSHOT as described on #4462 .
However, I didn't change swagger-parser dependency version to 1.0.24 as part of this PR since I didn't know what's the decision with issue 4462.