[C#][Nancy] Updated Nancy from 1.4.1 to 1.4.3 #4482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jimschubert
reviewed
Jan 3, 2017
| <ItemGroup> | ||
| <Reference Include="Nancy, Version=1.4.1.0, Culture=neutral, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\packages\Nancy.1.4.1\lib\net40\Nancy.dll</HintPath> | ||
| <Reference Include="Nancy, Version=1.4.2.0, Culture=neutral, processorArchitecture=MSIL"> |
Contributor
There was a problem hiding this comment.
Is 1.4.2 on this line correct? Or is this a typo?
Contributor
Author
There was a problem hiding this comment.
I know it's weird, but I did a nuget update-package on the petstore example and this is exactly how it modified the project file. It compiled so i didn't ask any questions.
Contributor
There was a problem hiding this comment.
That is weird. Nuget does that sometimes, I just wanted to check that it wasn't a typo. I think this version is the version from nuspec while the following line is from assembly info.
Contributor
Author
There was a problem hiding this comment.
yeah and it's a major pain to keep the two consistent with very little benefit.
Contributor
|
@simo9000 thanks for the PR, which has been merged into master. |
wing328
changed the title
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Updating the Nancy reference to version 1.4.3 in the project and packages config mustache files