Skip to content

Conversation

@wy-z
Copy link
Contributor

@wy-z wy-z commented Jan 4, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/go-petstore.sh and ./bin/security/go-petstore.sh if updating the go (e.g. php, ruby, python, etc) code generator or go client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

  • Use pointers to avoid circular references
  • Abandon omitempty tag when the field is required

wy-z added 2 commits January 4, 2017 18:37
Signed-off-by: weiyang <weiyang.ones@gmail.com>
Signed-off-by: weiyang <weiyang.ones@gmail.com>
@wy-z wy-z changed the title Optimize go model [go][model] Use pointers to avoid circular references Jan 4, 2017
@wing328
Copy link
Contributor

wing328 commented Jan 5, 2017

@wy-z thanks for the PR but I think it should be filed against 2.3.0 as it's a breaking change.

Here is the related discussion: #2330

cc @neilotoole @guohuang @antihax

@wing328 wing328 added this to the v2.2.2 milestone Jan 5, 2017
@wy-z
Copy link
Contributor Author

wy-z commented Jan 6, 2017

@wing328 ok~
It seems that #4440 is better~

@wy-z wy-z closed this Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants