Skip to content

Conversation

@wy-z
Copy link
Contributor

@wy-z wy-z commented Jan 6, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

  • Use pointers to avoid circular references
  • Abandon omitempty tag when the field is required

wy-z added 2 commits January 6, 2017 11:20
Signed-off-by: weiyang <weiyang.ones@gmail.com>
Signed-off-by: weiyang <weiyang.ones@gmail.com>
@wy-z
Copy link
Contributor Author

wy-z commented Jan 6, 2017

@wing328 It seems that #4440 has not modified model.mustache, so this PR may be useful~

@wy-z
Copy link
Contributor Author

wy-z commented Jan 6, 2017

@wing328 After reading #2330 carefully, I found that the problem was more complex than I thought~
I closed the PR.

@wy-z wy-z closed this Jan 6, 2017
@wing328 wing328 added this to the v2.2.2 milestone Jan 6, 2017
@wy-z wy-z deleted the optimize_go_model branch December 13, 2017 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants