[Jaxrs-Resteasy] Add beanvalidation annotations #4506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfiala
changed the title
wing328
reviewed
Jan 9, 2017
| public class JavaResteasyServerCodegen extends AbstractJavaJAXRSServerCodegen implements JbossFeature { | ||
| public class JavaResteasyServerCodegen extends AbstractJavaJAXRSServerCodegen implements JbossFeature, BeanValidationFeatures { | ||
|
|
||
| protected boolean useBeanValidation = true; |
Contributor
There was a problem hiding this comment.
Please use 4-space instead of tab.
What about setting useBeanValidation to false to start with similar to what we've done for Java API client?
Contributor
Author
There was a problem hiding this comment.
Cleaned the tabs, I set useBeanValidation=true because @cbornet suggested to do so (i.e. BeanValidation is a basic feature every language should support automatically). Of course we can also set to false, please advise what is preferred?
3 tasks
Contributor
Author
|
@wing328 pls review especially this pr soon, as I'd like to rework the resteasy language... |
Contributor
|
@jfiala let me review it now... |
Contributor
|
@jfiala I did some tests and the results looked good. For rework, I definitely welcome the idea and believe the change should target |
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
* add beanvalidation to jaxrs-resteasy swagger-api#4091 * replace tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
add beanvalidation annotation support to jaxrs-resteasy
for details see #4091