[Jaxrs-cxf-cdi] Add beanvalidation annotations #4507
Conversation
|
@jfiala I pulled this change locally, ran Did you get similar errors after updating |
* [maven-plugin] allow for ignore file override
The .swagger-codegen-ignore file is beneficial for existing source
directories to provide pattern-based exclusion rules for existing source
to be ignored by swagger codegen. Until now, there's been no utility
other than skipOverwrite to modify the initial generation of code
(either via CLI or maven plugin).
This commit adds support for an ignoreFileOverride option to both the
CLI and the maven plugin.
Example CLI usage:
```
java -jar swagger-codegen.jar generate \
-i swagger.json -l csharp \
-o target --ignore-file-override /path/to/ignore-file
```
Example Maven Plugin configuration:
```
<build>
<plugins>
<plugin>
<groupId>io.swagger</groupId>
<artifactId>swagger-codegen-maven-plugin</artifactId>
<version>2.2.2-SNAPSHOT</version>
<executions>
<execution>
<goals>
<goal>generate</goal>
</goals>
<configuration>
<inputSpec>${project.basedir}/src/main/resources/swagger.yaml</inputSpec>
<language>csharp</language>
<invokerPackage>io.swagger</invokerPackage>
<modelPackage>io.swagger.models</modelPackage>
<apiPackage>io.swagger.apis</apiPackage>
<ignoreFileOverride>/Users/jim/projects/swagger-codegen/.sample-ignore</ignoreFileOverride>
<configOptions>
</configOptions>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
```
* [maven-plugin] update new javadocs
* fix bad merge due to missing }
…gger-codegen into jaxrs_cxf_cdi_beanval
|
@wing328 I've had this numerours times, the generated samples are most of the time outdated, pls see #4087 for a suggestion to get this fixed. The bugs that have already been present (and have nothing to do with the beanvalidation issue I did) are:
I fixed all these for now so they at least compile. |
|
pls note that the PR here shows too many changes, if I go to my repo and compare I see 58 files changes opposed to 77 files here. I did the rebase like this: |
|
I think rebasing/recreating this might be a good idea. For example, I'm seeing changes for setIgnoreFilePathOverride, Ruby, jaxrs-spec samples, and PHP, which clearly have nothing to do with bean validation. Other comments:
|
|
@nickcmaynard Thx for your comment.
Pls add review comments to the newly created PR #4615, unfortunately the PR's compare view doesn't get updated after I'm doing a rebase, pls let me know if there is a better way than recreating the PR to update the compare view with the real changes in the branch. |
3 participants
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
add beanvalidation annotation support to jaxrs-cxf-cdi
for details see #4091