Skip to content

Conversation

@sreeshas
Copy link
Contributor

@sreeshas sreeshas commented Jan 6, 2017

PR checklist

  • [ x] Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Swagger-Codegen's CodegenResponse class did not support vendor extensions even though OpenAPI Spec supported it. This change enables support for vendor extensions in CodegenResponse.

Issue #4022 has more details.

@wing328
Copy link
Contributor

wing328 commented Jan 7, 2017

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the v2.2.2 milestone Jan 7, 2017
@sreeshas sreeshas force-pushed the topic/sreeshas/support_codegenresponse_vendorextensions branch 3 times, most recently from 3d72e4e to 03f47dc Compare January 7, 2017 20:22
@sreeshas sreeshas force-pushed the topic/sreeshas/support_codegenresponse_vendorextensions branch from 03f47dc to a43d469 Compare January 7, 2017 20:25
@sreeshas
Copy link
Contributor Author

sreeshas commented Jan 7, 2017

@wing328 does it look okay now? I changed the author email.

@wing328 wing328 merged commit 81b5b78 into swagger-api:master Jan 8, 2017
@wing328
Copy link
Contributor

wing328 commented Jan 8, 2017

@sreeshas yup. PR merged into master. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants