Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add triple-mustache to all instances of vendorExtensions.extraAnnotation #4553

Merged
merged 1 commit into from
Jan 13, 2017
Merged

[Java] Add triple-mustache to all instances of vendorExtensions.extraAnnotation #4553

merged 1 commit into from
Jan 13, 2017

Conversation

ThatJoeMoore
Copy link
Contributor

@ThatJoeMoore ThatJoeMoore commented Jan 12, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

This covers the usages that weren't fixed in #3825

Triple mustache is required because annotations may contain chars like
"=" that would be mistakenly encoded - see #3754

Notes

  • Updating the samples didn't change anything in the servers. There were a bunch of unrelated changes to the client samples that belong in a separate commit/PR (mostly the addition of Capitalization.java)
  • I'm almost certain that the changes to Mustache documented in Java: Latest JMustache breaks bigDecimalAsString #3754 will have broken other generators, but I don't even know where to begin looking for them.

…ion.

This covers the usages that weren't fixed in #3825

Triple mustache is required because annotations may contain chars like
"=" that would be mistakenly encoded.
@wing328
Copy link
Contributor

wing328 commented Jan 13, 2017

@ThatJoeMoore thanks for the PR. The change looks good to me.

@wing328 wing328 merged commit d40f7a4 into swagger-api:master Jan 13, 2017
@ThatJoeMoore ThatJoeMoore deleted the triple-mustache-annotations branch January 15, 2017 06:47
@wing328 wing328 changed the title Add triple-mustache to all instances of vendorExtensions.extraAnnotation [Java] Add triple-mustache to all instances of vendorExtensions.extraAnnotation Feb 20, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
…ion. (swagger-api#4553)

This covers the usages that weren't fixed in swagger-api#3825

Triple mustache is required because annotations may contain chars like
"=" that would be mistakenly encoded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants