Skip to content

Conversation

@me717
Copy link
Contributor

@me717 me717 commented Jan 17, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Set embedded template directory when generating Javascript code
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@me717 me717 changed the title Set embedded templates directory when generating Javascript code [Javscript] Set embedded templates directory when generating Javascript code Jan 17, 2017
@wing328 wing328 added this to the v2.2.2 milestone Jan 19, 2017
@wing328
Copy link
Contributor

wing328 commented Jan 19, 2017

@me717 thanks for the PR. I found several generators missing the embeddedTemplateDir as well:

swagger-codegen|master⚡ ⇒ grep -R templateDir modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/* | grep -v embeddedTemplateDir
modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/BashClientCodegen.java:    templateDir = "bash";
modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/CppRestClientCodegen.java:        templateDir = "cpprest";
modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/GoClientCodegen.java:        templateDir = "go";
modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JMeterCodegen.java:    templateDir = "JMeter";
modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JavascriptClientCodegen.java:        templateDir = "Javascript";

I'll file a separate PR to clean those up.

@wing328 wing328 merged commit ccb3385 into swagger-api:master Jan 19, 2017
@wing328 wing328 changed the title [Javscript] Set embedded templates directory when generating Javascript code [JS] Set embedded templates directory when generating Javascript code Feb 20, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants