Skip to content

Conversation

@JLLeitschuh
Copy link
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

In a previous PR I forgot to change the rm line to reflect the file that needs to be removed before running the generator.

Related #4439

@wing328 wing328 added this to the v2.2.2 milestone Jan 24, 2017
@wing328 wing328 merged commit efd0732 into swagger-api:master Jan 25, 2017
@wing328 wing328 changed the title Fix the rm to remove the correct file in two spring generation bash scripts [Java][Spring] Fix the rm to remove the correct file in two spring generation bash scripts Feb 21, 2017
acramatte added a commit to comerge/swagger-codegen that referenced this pull request Mar 7, 2017
* upstream/master: (261 commits)
  tests, fix for swagger-api#4647.  Proper escaping project name per npmjs (swagger-api#4648)
  Add support for read-only values in spring model (swagger-api#4629)
  new batch file to exec all JS petstore batch files
  update JS petstore client
  Fix the `rm` to remove the correct file in two spring generation bash scripts (swagger-api#4630)
  fix for allowable values, swagger-api#4645 (swagger-api#4646)
  Issue 4637 Fix for ci build (swagger-api#4643)
  Added single quotes -- fixes bug where generated client throws an 'Uncaught Reference Error'.
  add https://pagertree.com/
  add https://neverfail.com/
  Removed pet variable from Javascript api_test Mustache file, which was undefined and is not necessary here. This should fix issue swagger-api#4608. (swagger-api#4624)
  Removed pet variable from Javascript api_test Mustache file, which was undefined and is not necessary here. This should fix issue swagger-api#4608.
  update ts angular2 petstore samples
  Enum constructFromObject should return value (swagger-api#4613)
  update js promise petstore sample
  Fix Issue 4554 - handle 204 server response in javascript (swagger-api#4604)
  Fix model prefix/suffix with incorrect camelization (swagger-api#4621)
  better handling of reserved words in models, operationId (swagger-api#4620)
  [java] Improve pom.xml to qualify for publishing to Maven central (swagger-api#4616)
  rebuilt samples
  ...
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants