[JAX-RS] Beanvalidation Final Cleanup #4091 #4635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Contributor
Author
|
@wing328 this PR concludes the beanvalidation api impl. for all jaxrs-languages, it moves the beanvalidation to AbstractJavaJAXRSServerCodegen.java as well as evens out all beanValidation.mustache to add support for @DecimalMin/@DecimalMax to java/jaxrs-cxf. |
3 tasks
Contributor
Author
|
@wing328 can you pls also merge this one in so I can continue with the other issues? |
Contributor
|
@jfiala sure. I'll review tomorrow. |
Contributor
|
@jfiala I've resolved the merge conflicts and merged the changes into master. |
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
see #4091, Final Cleanup