Skip to content

Conversation

@amingilani
Copy link
Contributor

PR checklist

  • [ x ] Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Newly generated code in Rails 5 readme wrongly says the code was generated for "Sinatra". This patch changes it to read "Ruby on Rails".

Fixes #4655

@wing328 wing328 merged commit 347d477 into swagger-api:master Jan 26, 2017
@wing328
Copy link
Contributor

wing328 commented Jan 26, 2017

@amingilani thanks for the fix.

@wing328 wing328 added this to the v2.2.2 milestone Jan 26, 2017
@wing328 wing328 changed the title Minor: fix incorrect reference in Rails 5 readme from "Sinatra" to "Ruby on Rails" [Ruby][Rails] fix incorrect reference in Rails 5 readme from "Sinatra" to "Ruby on Rails" Feb 21, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants