Skip to content

Conversation

@abaruni
Copy link
Contributor

@abaruni abaruni commented Feb 9, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

addition of boolean data type flags in CodegenResponse and logic to set them in DefaultCodegen

@wing328
Copy link
Contributor

wing328 commented Feb 13, 2017

@abaruni Thanks for the PR. We've started migrating Boolean to boolean in the Codegen classes. I wonder if you can rebase this PR on the latest master or pull the latest master and then submit a new PR.

@wing328 wing328 added this to the v2.2.2 milestone Feb 13, 2017
@abaruni
Copy link
Contributor Author

abaruni commented Feb 13, 2017

@wing328 i've updated this pull request with the latest contents of master

@wing328
Copy link
Contributor

wing328 commented Feb 14, 2017

@abaruni thanks. The PR looks good to me.

@wing328 wing328 merged commit 2447412 into swagger-api:master Feb 14, 2017
@wing328 wing328 changed the title Issue 4742 Addition of boolean data type flags in CodegenResponse and logic to set them in DefaultCodegen Feb 22, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
* add boolean datatype flags to CodegenResponse and logic to set them in DefaultCodegen

* use Boolean.TRUE.equals to check for isResponseBinary or isResponseFile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants