Skip to content

Conversation

@BastiOfBerlin
Copy link
Contributor

@BastiOfBerlin BastiOfBerlin commented Feb 10, 2017

ignore dist folder

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Adding the dist folder to .gitignore so that it isn't packed by npm package.

ignore dist folder
@wing328
Copy link
Contributor

wing328 commented Feb 13, 2017

@BastiOfBerlin thanks for the PR, which looks good to me.

@wing328 wing328 merged commit a956966 into swagger-api:master Feb 13, 2017
@wing328
Copy link
Contributor

wing328 commented Feb 13, 2017

@BastiOfBerlin shall we do the same for typescript-angular, typescript-node and typescript-fetch as well?

cc @Vrolijkx

@BastiOfBerlin BastiOfBerlin deleted the patch-1 branch February 13, 2017 11:27
@BastiOfBerlin
Copy link
Contributor Author

@wing328 sounds reasonable

Copy link
Contributor

@Vrolijkx Vrolijkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple change but don't forget to rerun the samples.

@BastiOfBerlin BastiOfBerlin restored the patch-1 branch February 14, 2017 10:02
@wing328
Copy link
Contributor

wing328 commented Feb 15, 2017

FYI. Filed #4799 to update other TS generators.

@wing328 wing328 changed the title Update gitignore to ignore dist folder [TS][Angular2] Update gitignore to ignore dist folder Feb 20, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants