[Scala] Port the optional/enum template logic from async-scala to the regular scala client #4849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic for enum Just going to avoid enum for now, considering I'm not sure what scala client will be official
Contributor
|
@log0ymxm thanks for the PR. We'll review let you know if we've any question. In 2.3.0 branch, we'll merge async-scala and scala into one single client to avoid duplicated efforts in these 2 clients: #4855 |
Contributor
|
@log0ymxm the change looks good to me. PR merged into master. cc @clasnake |
wing328
changed the title
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
… scala client (swagger-api#4849) * Port the optional/enum template logic from async-scala to the regular scala client * oops, accidently pulled template from akka-scala which has custom logic for enum Just going to avoid enum for now, considering I'm not sure what scala client will be official * Update tests to use option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Port the option and enum logic from the scala-async template into this one. What is considered a breaking change? This will certainly require anyone generating scala templates to update their code should they regenerate with this template, does that count as breaking? If so I'll recreate the PR onto the right branch.
I know that the plans are to merge the scala & async-scala generators, which project will be considered the main project? I initially tried using the async-scala generator and had some small issues, and switched to this generator just because it was easier to get working initially.