Skip to content

Conversation

@wing328
Copy link
Contributor

@wing328 wing328 commented Feb 27, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

For #4295

@ePaul
Copy link
Contributor

ePaul commented Mar 1, 2017

I'm not sure if this is feasible on a project of the change frequency like this one ... you get conflicts before a review (or even the CI build) is possible. Though 👍 for the idea.

@wing328
Copy link
Contributor Author

wing328 commented Jun 16, 2017

Yup, closing this one as this will result in a lot of merge conflicts. We'll try to merge more outstanding PRs into master/2.3.0 before running mvn formatter:format again.

@wing328 wing328 closed this Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants