[Java][Spring] use {{baseName}} instead of {{paramName}} for Spring annotations #4875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done so I can see my own changes better.
Contributor
Author
|
Rebased onto master to trigger CI again. |
wing328
changed the title
ePaul
pushed a commit
to ePaul/swagger-codegen
that referenced
this pull request
Mar 4, 2017
Somehow I omitted this in swagger-api#4875.
ePaul
pushed a commit
to ePaul/swagger-codegen
that referenced
this pull request
Mar 5, 2017
Somehow I omitted this in swagger-api#4875.
wing328
pushed a commit
that referenced
this pull request
Mar 6, 2017
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
* Update spring samples with current code. This is done so I can see my own changes better. * Regenerate samples after 2.2.2. * use baseName instead of paramName for spring annotations. * update spring petstore samples to show the effects.
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
Somehow I omitted this in swagger-api#4875.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully fixes #1219 and #4870 (and possibly other issues).
PR checklist
./bin/spring-all-petstore.shto update Petstore sample so that CIs can verify the change.2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
This includes the changes of #4874 – view just the last commit in the diff, or merge that PR before this one to see the effects of the actual changes on the samples here.
As proposed by @wing328 in #4870, I tried to use
{{baseName}}instead of{{paramName}}for the values of some generated Spring annotations. I used this for all parameter types: path parameters, form parameters and query parameters. Header parameters were already correct.