[Java][MSF4J] Fix parameter names with {{baseName}} #4917
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.→ bin/java-msf4j-petstore-server.sh (
once before the change (Update samples for MSF4J after 2.2.2. #4915) and once againafter the change (with no effect)).Description of the PR
(This includes the changes from #4915. Should look better after merging this, or look at just the last commit. I'm already opening the PR so CI can look at it.)→ now rebased.This is a part of the fixes for meta issue #4898.
This fixes a wrong parameter mapping for file upload form parameters, as well as non-file-upload form parameters with the
x-multipartvendor extension, when the parameter names in the OpenAPI definition get transformed to different names (e.g. to confirm to camelCase, or to avoid reserved words).I didn't succeed to actually test this, not having a MSF4J project here.
The petstore example has no file upload form parameter where this would make a difference.
Needs review from Java/MSF4J experts. /cc @cbornet @xhh @kolyjjj