Skip to content

Conversation

@ePaul
Copy link
Contributor

@ePaul ePaul commented Mar 13, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change.
    → updated all the samples (except clojure and scalatra's build.sbt change – those were fixed in master, but not yet here).
  • Filed the PR against the correct branch: sync_master_230 (which is intended to be later merged into 2.3.0)

Description of the PR

This updates all the samples after the merge of master and 2.3.0 so CI (and people) can check the results.

@ePaul ePaul force-pushed the update-samples-for-sync_master_230 branch from 08b29da to 342baee Compare March 13, 2017 18:12
@ePaul ePaul force-pushed the update-samples-for-sync_master_230 branch from 342baee to 6cf4cce Compare March 13, 2017 18:32
(except clojure + scalatra, because those are broken, will fixed with later master merge.)
@ePaul ePaul force-pushed the update-samples-for-sync_master_230 branch from 6cf4cce to 3a48ba8 Compare March 13, 2017 18:51
@ePaul
Copy link
Contributor Author

ePaul commented Mar 13, 2017

Okay, at least Travis likes it.
Appveyor has problems finding io.swagger:swagger-parser:jar:1.0.26-SNAPSHOT in Sonatype,
Shippable has problems with JAVA_HOME.

I guess the latter will be fixed by merging in a newer master version.

@ePaul ePaul mentioned this pull request Mar 13, 2017
3 tasks
@ePaul
Copy link
Contributor Author

ePaul commented Mar 14, 2017

As discussed in #5056, I updated swagger-parser to 1.0.28. I also cherry-picked two commits from @fehguy from master (fixes for BashClientCodegen, which broke by the update). (I will rebase #5056 onto this one.)

@ePaul ePaul force-pushed the update-samples-for-sync_master_230 branch from a9def07 to aba5abd Compare March 14, 2017 11:54
@ePaul ePaul mentioned this pull request Mar 14, 2017
3 tasks
@wing328 wing328 merged commit aba5abd into swagger-api:sync_master_230 Mar 15, 2017
@wing328 wing328 added this to the v2.3.0 milestone Mar 15, 2017
@ePaul ePaul deleted the update-samples-for-sync_master_230 branch March 15, 2017 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants