[Scala] Fix sample script to set the correct artifact ID in the generated POM #5094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ePaul thanks for the PR, or we can leverage .swagger-codegen-ignore to prevent the file being overwritten in the next run (other clients also use this approach) |
Contributor
|
Actually your approach may work better as we need to update dependency in pom.xml to the latest version from time to time. |
3 tasks
Contributor
Author
|
@wing328 I was not aware that .swagger-codegen-ignore is used for this purpose. Should I do the same change for other generators too? (Possibly in a separate PR.) |
Contributor
Yup, if you've time, please do. Thanks. (beware there might be other custom changes made to the auto-generated pom.xml) |
pgrm
added a commit
to apaleo/swagger-codegen
that referenced
this pull request
Mar 19, 2017
* [Swift] Detect file type in Swift codegen * Fix Issue swagger-api#5063 (deleting wrong sample files) (swagger-api#5064) * Update samples for springboot, spring-delegate, spring-delegate-j8. * Issue swagger-api#5063: delete samples in the correct directory. * fix link to Cummins * Update wordnik.yaml * Update wordnik.yaml * add https://github.com/christopheradams/elixir_style_guide * add https://github.com/inaka/erlang_guidelines * [Haskell] Fix broken client/server compilation errors (swagger-api#5097) * Remove dead legacy code * Update cosmetics according to Haskell standard practices * Fix failing pattern matching for lookupEither * Bump to latest dependencies without any breaking changes * Remove duplicate instance declarations already existing in Servant.API.Verbs * Fix double Java/Haskell escapement bug * Re-generate Petstore sample client/server * Add Selective Generation support to the Maven plugin. (swagger-api#5036) * Updated maven plugin to allow for selective generation * Documentation of Selective generation options. * Update petstore samples for scala client. (swagger-api#5092) * Update petstore samples for scala client. * Fix missing dependency problem. * Fix sample script to set the correct artifact ID in the generated POM (swagger-api#5094) * Update samples for akka. * Have akka-scala-petstore scripts set the correct artifact names * Update akka-scala samples again. * Update samples for C#/SwaggerClientWithPropertyChanged. (swagger-api#5095) * Swift3 enum: number variable names fix (swagger-api#5060) * Swift3 enum: number variable names fix Swift3 generator: added 'number' prefix to enum variable names that start with a number * Fixed Swift3 enum variable names starting with number (prefixed with '_') and added test cases * Swift3 enum var names: made sure to keep the next word after a number in lower case * add jackson dependencies to pom for cxf-client swagger-api#4924 (swagger-api#5032) * add petstore sample for jaxrs-cxf-client, update travis ci (swagger-api#5111) * fix path with {{{ .. }}} in c# api mustache file (swagger-api#5112) * Updated feign library to use latest version of OpenFeign and Jackson. (swagger-api#5114)
wing328
changed the title
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
…swagger-api#5094) * Update samples for akka. * Have akka-scala-petstore scripts set the correct artifact names * Update akka-scala samples again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.→ bin/akka-scala-petstore.sh (twice, once before and once after the change).
Description of the PR
This was first just meant to update the Akka samples, there are no code changes here.
The first commit (updating samples from the script) undoes part of the change from #5073, which changed the name + artifact ID manually.
This shows that the default artifact ID is not what is used when running CI.
The second commit changes the sample update scripts to set the correct
--artifact-idparameter.The third commit updates the samples again, showing that everything is fine now. (There is a change in the generated reference.conf, not sure if it is relevant.)