[C#] Issue #5196: make package GUID non-random for the C# samples. #5198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ePaul
changed the title
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
…samples. (swagger-api#5198) * Issue swagger-api#5196: make package GUID non-random for the C# samples. * Also change the .bat files for C#.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.→ bin/csharp-petstore.sh + bin/csharp-property-changed-petstore.sh.
Description of the PR
This changes the C# sample generation scripts to pass a fixed packageGuid parameter.
The effect is that the generated samples don't change randomly with every update, obfuscating the real changes. (This is a part of #5196.)
The functionality for this was already build in #1941, when the project files with GUIDs were added.
I chose the fixed GUIDs as the latest random value from master, with the effect that an update now doesn't change anything anymore. (When merging into 2.3.0 and regenerating, you'll get a change once.)
(I also changed the .bat files, though I'm not able to test this here.)