Updating (almost) all samples. #5281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
Author
|
Tests fail for feign, likely caused by the parameter name change. I'll have a look whether I can fix them (and whether this is actually a bug). |
Contributor
Author
|
I opened a separate issue #5296 for the feign problem, and will revert the update for this file so CI can test that the rest works fine. |
ePaul
force-pushed
the
update-all-samples
branch
from
df38a1a to
7127c99
Compare
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change.→ bin/run-all-petstore, except for the changes in [Java][JaxRS][Spring-MVC] Update samples for jaxrs with Jersey 1/2 and for spring-mvc #5212 and the date-depending stuff in some NPM package version numbers (see [Suggestion] Remove timestamp from auto-generated code/documentation #3084).
Description of the PR
No code changes, just updating the samples so later updates can see what actually changed.
This mostly contains parameter name changes from #5267 (which changed one of the YAMLs), as well as some regexp fixes from #5189.