Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize unknown subtypes #5437

Conversation

gstarnberger
Copy link

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Fix for #5436. Makes Jackson fall back to a default class when the client does not know the polymorphic subtype that's returned by the server.

@wing328
Copy link
Contributor

wing328 commented Apr 23, 2017

@gstarnberger thanks for the PR.

cc @ePaul @cbornet @jfiala

@gstarnberger
Copy link
Author

Closing this pull request due to the problems discussed in #5596. The solution suggested by @bbdouglas (#5597) is a better fix for this issue.

@gstarnberger gstarnberger deleted the deserialize_unknown_subtypes branch May 10, 2017 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants