Skip to content

Conversation

@caseyfw
Copy link
Contributor

@caseyfw caseyfw commented May 24, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

This change uses the official maven docker image's method to set the user in the docker container to the same user who invokes the run-in-docker.sh script. The outcome of this is that all the artefacts generated by the container (m2 cache in home dir, target directories, output client and server code, etc) are owned by the expected user instead of root.

@caseyfw caseyfw changed the base branch from 2.3.0 to master May 24, 2017 13:48
@caseyfw caseyfw changed the base branch from master to 2.3.0 May 24, 2017 13:48
@caseyfw
Copy link
Contributor Author

caseyfw commented May 24, 2017

Closing this to re-roll for master branch.

@caseyfw caseyfw closed this May 24, 2017
@caseyfw caseyfw deleted the docker-run-as-non-root branch May 24, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant