Skip to content

Conversation

@isman-usoh
Copy link
Contributor

@isman-usoh isman-usoh commented Jul 16, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Fix generate additionalProperties array type #6081

@wing328
Copy link
Contributor

wing328 commented Jul 20, 2017

@isman-usoh thanks for the PR.

cc @Vrolijkx @taxpon @sebastianhaas @kenisteward @TiFu

@wing328 wing328 added this to the v2.3.0 milestone Jul 20, 2017
@wing328
Copy link
Contributor

wing328 commented Jul 23, 2017

@isman-usoh I did a test and confirmed the fix works

export interface Model1 {
    [key: string]: Array<Pet>;
}

@damienpontifex
Copy link
Contributor

damienpontifex commented Jul 25, 2017

Just reviewing my PR in #6109 and wondering if this change should be in the AbstractTypeScriptClientCodegen class if it's valid to all TypeScript?

@kenisteward
Copy link
Contributor

kenisteward commented Jul 26, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants