Skip to content

Conversation

@MZinchenko
Copy link
Contributor

@MZinchenko MZinchenko commented Oct 18, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming langauge.

Description of the PR

Changes in Java Spring only:

@wing328
Copy link
Contributor

wing328 commented Oct 19, 2017

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@MZinchenko
Copy link
Contributor Author

MZinchenko commented Oct 20, 2017 via email

@MZinchenko MZinchenko changed the title JavaSpring: Issue #4680 and objectMapper issue [Java][Spring] Issue #4680 and objectMapper issue Oct 20, 2017
@MZinchenko MZinchenko changed the title [Java][Spring] Issue #4680 and objectMapper issue [Java][Spring][Server] Issue #4680 and objectMapper issue Oct 20, 2017
@wing328
Copy link
Contributor

wing328 commented Nov 2, 2017

@cbornet do we still need this PR? I think your recent PR may have fixed it.

@cbornet
Copy link
Contributor

cbornet commented Nov 2, 2017

I think fb18b3b is still relevant but 35c255a is not needed anymore

@wing328
Copy link
Contributor

wing328 commented Nov 5, 2017

@MZinchenko do you mind submitting another PR with just fb18b3b?

You may find git cherry-pick useful to do that.

@MZinchenko
Copy link
Contributor Author

MZinchenko commented Nov 5, 2017 via email

@wing328
Copy link
Contributor

wing328 commented Nov 13, 2017

Closed via #6890

@wing328 wing328 closed this Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants