Skip to content

Conversation

@demtnt
Copy link
Contributor

@demtnt demtnt commented Nov 1, 2017

As per documentation https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/bind/annotation/RequestPart.html @RequestParam should be used instead of @requestpart if not file.

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming langauge.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@wing328
Copy link
Contributor

wing328 commented Nov 2, 2017

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Contributor

wing328 commented Nov 2, 2017

@cbornet
Copy link
Contributor

cbornet commented Nov 2, 2017

@demtnt please update the samples for spring

@wing328
Copy link
Contributor

wing328 commented Nov 13, 2017

Annotation that can be used to associate the part of a "multipart/form-data" request with a method argument.

@demtnt What if the request content-type is x-www-form-urlencoded? Would this change still be applicable?

@wing328
Copy link
Contributor

wing328 commented Nov 13, 2017

Related: #6438

@wing328
Copy link
Contributor

wing328 commented Nov 27, 2017

@wing328 wing328 merged commit dca7a15 into swagger-api:master Nov 27, 2017
@wing328 wing328 changed the title Formdata parameter fix in spring [Java][Spring] Formdata parameter fix Nov 27, 2017
@demtnt demtnt deleted the issue-6438 branch April 19, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants