[docker] Update root Dockerfile #6870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Based on discussions in #6836, this is a modification to the root Dockerfile which is intended to allow developers a clean sandbox to evaluate local changes.
NOTES:
This image is not the image published to swaggerapi/swagger-codegen-cli or swaggerapi/swagger-generator. Those images are containers encapsulating the compiled .jars and a java runtime for each.
I've removed swagger-generator from being cached within this image. The assumption here is that anyone working on local swagger-generator modifications will likely be running that locally. Since this root Dockerfile is specifically setup to run as the locally modified CLI code, it doesn't make a lot of sense to include the ~129MB layer for swagger-generator (which doesn't get built by maven in the image). This could be revisited if it's a concern.
Some layering optimizations were made (see linked PR).
/cc @kenjones-cisco