[Scala][Finch] Adding security definitions to Finch

[erikwj]

@jimschubert: An addition to #6818
Added scalafix for cleanup
fixed an issue with the path parameters (String :: String vs string :: string)
Some refactoring of the code
No tests yet.

[jimschubert]

Thanks. I'll check this out in the next day or two. I know the Finch generator is a little bit of a beast as FP requires jumping through more hoops than OOP in mustache templates. Really appreciate the work!

[wing328]

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

[erikwj]

Ok thanks didn't pay attention to it. Will fix it. Tonight

…

On Mon, Nov 6, 2017 at 4:04 AM, wing328 ***@***.***> wrote: Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/ contributors. Let me know if you need help fixing it. Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ# how-can-i-update-commits-that-are-not-linked-to-my-github-account — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6891 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADsQbjLhXUIj2MPo8MvDBAX1d-QMqHFOks5szndUgaJpZM4QSh8K> .

[erikwj]

@wing328 a full rewrite as explained in post, didn't work out. So merged the commits and added author manually. Let me know if you have any comments

[wing328]

Upgrade Note

date-time is mapped to "ZonedDateTime" instead of "LocalDateTime".

To roll back the change, please use the --type-mappings option.

[jimschubert]

@erikwj @wing328 hey, I just saw the upgrade note from earlier today. I had planned on reviewing the new PR and never saw the update regarding the merge & manual author update. Sorry about that.

fwiw, the change looks good and I had no additional comments.