[CppRest] Add Object and fix modelbase includes
#6905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
Update: I've had a second look and this actually doesn't solve the issue mentioned in #6512.. |
fvarose
changed the title
Object and fix modelbase includes
Contributor
Author
|
This PR is now ready to be reviewed again. It fixes #6512. |
stkrwork
approved these changes
Nov 21, 2017
Contributor
Contributor
|
hi all |
Contributor
|
@murzic4 do you mind filing a PR to add those? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This PR addresses two issues:
TheObject.hheader file does not exist, we replace it withModelBase.hwhich provides the expected functionality (fix [CPPREST] Arbitrary object type results in a compilation error (missing Object.h) #6512). This was seemingly an early copy and paste mistake that wasn't caught by the PetStore example.Edit (14/11/2017): this PR provides a simple implementation of
Object, wrapped aroundweb::json::valuefrom casablanca. This fixes [CPPREST] Arbitrary object type results in a compilation error (missing Object.h) #6512.I've updated the sample code accordingly and managed to compile it without any problems.
This change has also been tested successfully on a codebase where two separate APIs coexist (which wasn't possible at all before).