Skip to content

Conversation

@Gingonic
Copy link
Contributor

@Gingonic Gingonic commented Nov 13, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

For the PHP Symfony generation this import

use` Swagger\Server\Service\StrictJsonDeserializationVisitor;

is wrong as the class is sitting in the same package as the JMSSerializer class.
This results in exception when the serializer is used

@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @naelrashdeen

@wing328
Copy link
Contributor

wing328 commented Nov 14, 2017

@Gingonic thanks for the PR. Please run ./bin/php-symfony-petstore.sh to update PHP Symfony Petstore sample.

@Gingonic
Copy link
Contributor Author

@wing328 Sorry for that. Added the sample tests passing.

@Gingonic
Copy link
Contributor Author

@wing328 I think this is ready. What are the next steps, will someone be assigned to this for review and merging?
Right now this bug makes the symfony bundle generator hardly unusable as you need to manually change the Serializer.
Note to whom ever has the same problem: you can generate once, fix the Serializer manually, then add the Serializer to the ignore list of the generator therefor letting it unchanged.

@wing328
Copy link
Contributor

wing328 commented Nov 27, 2017

@Gingonic thanks for the PR, which has been merged into master.

@wing328 wing328 merged commit a565a94 into swagger-api:master Nov 27, 2017
@wing328 wing328 changed the title Removed wrong import of StrictJsonDeserializationVisitor [PHP][Symfony] Removed wrong import of StrictJsonDeserializationVisitor Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants