[Rust] Match integer type to minimum and maximum constraints #6985
Conversation
|
The logic as you've described it (assuming I've understood) doesn't seem to cope with cases where the valid range is -(something large) to +(something small). You'll correctly pick a signed quantity, but the size will only be big enough for the positive max, not the negative max. I think you need to use the maximum and minimum to determine the size needed. |
|
You are right. I changed the calculation to use As a sensible default, I made I also added a test for the min / max constraints to int sizing logic, you can look at it, it makes the choices clearer. |
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors. Let me know if you need help fixing it. |
|
Thank you for noticing this. I fixed my local git config for the future, amended the commit and added my secondary email to my github account for good measure. |
|
Although the commit is now to my primary email, I noticed that my avatar picture for the commit is small, and the generic octocat is still shown behind. Let me know if this is normal or if it's something I should fix. |
| assertEquals(RustServerCodegen.matchingIntType(false, null, Long.MAX_VALUE), "i64"); | ||
| } | ||
|
|
||
| } |
| @@ -269,7 +262,7 @@ public String toApiName(String name) { | |||
|
|
|||
| /** | |||
| * Escapes a reserved word as defined in the `reservedWords` array. Handle escaping | |||
| * those terms here. This logic is only called if a variable matches the reserved words | |||
| * those terms here. This logic is only called if a variable matches the reseved words | |||
|
@fralalonde thanks for the PR, which has been merged into master. @bjgill thanks for reviewing the change. |
wing328
changed the title
@frol @farcaller
In rust-server, use rust integer types best matching the
format,minimumandmaximumschema constraints.Matching rules cover all rust standard int size, from 8 to 64bits, signed and unsigned, including
sizetypes.minimumis used to determine if the int type should be signed. Default is signed.maximumis used to determine the int size. Default isisizeorusize.formatsint32andint64can be used to force int size.uint32anduint64have been preserved, even though they are superseded by new code.minimumandmaximumconstraints also respects theirexclusiveflags if specified.