Skip to content

Conversation

@topce
Copy link
Contributor

@topce topce commented Nov 17, 2017

PR checklist

  • [ x] Read the contribution guidelines.
  • [x ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [x ] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [x ] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @kenisteward @wing328 @sebastianhaas

Description of the PR

It look like import '../rxjs-operators'; is not needed
since angular 4.3

@kenisteward
Copy link
Contributor

@topce beat me to the punch on this one. Have you tested to make sure that this still works with your client Locally?

Also I'd say that if we don't need the import then we shouldn't generate the file as the old way of using rxjs would end up importing more than we'd want. At some point we should figure out the proper wait to include lettable operators when the time comes.

@topce
Copy link
Contributor Author

topce commented Nov 17, 2017

@kenisteward
tested locally with latest angular 5.0.0 and it works .
did not have opportunity to test it with 4.3.0
hope it works because in some online examples
rxjs operator are not imported
Please check if you have time if it works with 4.3.0
You are right for import in angular 5.0.0
you can use lettable operators for more details please check blog post
Version 5.0.0 of Angular Now Available
for example:
import { catchError } from "rxjs/operators/catchError"; import { tap } from "rxjs/operators/tap";

@kenisteward
Copy link
Contributor

kenisteward commented Nov 17, 2017 via email

@topce
Copy link
Contributor Author

topce commented Nov 17, 2017

@kenisteward me too ;-)

@topce
Copy link
Contributor Author

topce commented Nov 23, 2017

@kenisteward @wing328
Any news on this one ?

@wing328
Copy link
Contributor

wing328 commented Nov 23, 2017

@kenisteward
Copy link
Contributor

kenisteward commented Nov 23, 2017 via email

@wing328 wing328 merged commit 8a0de97 into swagger-api:master Nov 24, 2017
@wing328 wing328 changed the title Remove rxjs operators [TypeScript][Angular] Remove rxjs operators Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants