-
Notifications
You must be signed in to change notification settings - Fork 6k
[TypeScript][Angular] Remove rxjs operators #6989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@topce beat me to the punch on this one. Have you tested to make sure that this still works with your client Locally? Also I'd say that if we don't need the import then we shouldn't generate the file as the old way of using rxjs would end up importing more than we'd want. At some point we should figure out the proper wait to include lettable operators when the time comes. |
|
@kenisteward |
|
Oh I use them now I was just asking :)
…On Fri, Nov 17, 2017, 8:59 AM topce ***@***.***> wrote:
@kenisteward <https://github.com/kenisteward>
tested locally with latest angular 5.0.0 and it works .
did not have opportunity to test it with 4.3.0
hope it works because in some online examples
rxjs operator are not imported
Please check if you have time
You are right for import in angular 5.0.0
you can use lettable operators for more details please check blog post
Version 5.0.0 of Angular Now Available
<https://blog.angular.io/version-5-0-0-of-angular-now-available-37e414935ced>
for example:
import { catchError } from "rxjs/operators/catchError"; import { tap }
from "rxjs/operators/tap";
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6989 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMPLtQUd3TnglsBAtqiKniZcxRqiTm08ks5s3ZFMgaJpZM4QiDLq>
.
|
|
@kenisteward me too ;-) |
|
@kenisteward @wing328 |
|
As long as it is locally test to not break anything I'm cool with it!
…On Thu, Nov 23, 2017, 12:20 PM William Cheng ***@***.***> wrote:
cc @TiFu <https://github.com/tifu> @taxpon <https://github.com/taxpon>
@sebastianhaas <https://github.com/sebastianhaas> @kenisteward
<https://github.com/kenisteward> @Vrolijkx <https://github.com/vrolijkx>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6989 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMPLtc5y4ucxa40kZGMZGZm51UY-tVBJks5s5alrgaJpZM4QiDLq>
.
|
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@kenisteward @wing328 @sebastianhaas
Description of the PR
It look like import '../rxjs-operators'; is not needed
since angular 4.3