Skip to content

Conversation

@craffael
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language: @jimschubert @mandrean

Description of the PR

This PR is a fix for issue #7024 . It contains three "major" modifications:

  • Map a swagger field with format: date to NodaTime.LocalDate instead of NodaTime.ZonedDateTime.
  • Adds a NancyFx JavaScriptPrimitiveConverter to (de)serialize LocalDate member variables in the body according to the RFC3339 standard.
  • Adds additional routine to Parameters.cs to parse LocalDate values.

@jimschubert
Copy link
Contributor

Seems a reasonable fix to me!

@wing328
Copy link
Contributor

wing328 commented Nov 27, 2017

Upgrade Note

date is mapped to "LocalDate?" instead of "ZonedDateTime?"

@wing328 wing328 added this to the v2.3.0 milestone Nov 27, 2017
@wing328 wing328 merged commit fc5ec62 into swagger-api:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants