Skip to content

Conversation

@shoshins
Copy link
Contributor

@shoshins shoshins commented Nov 23, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

#7026

@wing328
Copy link
Contributor

wing328 commented Nov 23, 2017

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@shoshins
Copy link
Contributor Author

Oh, thanks. I added commit email as secondary to my github account. Is it Ok?

@wing328
Copy link
Contributor

wing328 commented Nov 23, 2017

Looks good now.

cc @jgavris @ehyche @Edubits @jaz-ah to review

@jgavris
Copy link
Contributor

jgavris commented Nov 27, 2017

👍

@wing328 wing328 merged commit adda792 into swagger-api:master Nov 28, 2017
@wing328 wing328 changed the title #7026 [Swift] tvos support added [Swift] tvos support added Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants